Skip to content

fix(grid): scale grid thumbnails to fill the available tile width#17294

Merged
alperozturk96 merged 2 commits into
nextcloud:masterfrom
MaqsudMallick:fix/image-video-grid-items
Jul 21, 2026
Merged

fix(grid): scale grid thumbnails to fill the available tile width#17294
alperozturk96 merged 2 commits into
nextcloud:masterfrom
MaqsudMallick:fix/image-video-grid-items

Conversation

@MaqsudMallick

@MaqsudMallick MaqsudMallick commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Fixes #12627

@alperozturk96
alperozturk96 force-pushed the fix/image-video-grid-items branch from c191927 to ebfa193 Compare July 8, 2026 06:52
@alperozturk96
alperozturk96 requested a review from kra-mo July 8, 2026 06:53

@kra-mo kra-mo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, consistent with the ideas for the grid view on the web. (Mainly for large thumbnails.)

@tobiasKaminsky

Copy link
Copy Markdown
Member

Looks nice, consistent with the ideas for the grid view on the web. (Mainly for large thumbnails.)

I am unsure, since it then crops on the border of images, thus maybe loosing information on thumbnail?

@MaqsudMallick

Copy link
Copy Markdown
Contributor Author

@tobiasKaminsky I am unable to recreate the loss of thumbnail that you mentioned when comparing the web version to my PR. Any suggestions on how can I proceed?

Tried with images of different orientations:

image image

@github-actions

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@tobiasKaminsky

Copy link
Copy Markdown
Member

Thanks for checking.
I was maybe too brief.
Since this is a square thumbnail, it will crop on top/bottom in portrait mode (or left/right in landscape).

We discussed this and since it is consistent with web, I am also fine withit on Android.
Thanks for your contribution 🎉

@alperozturk96 please continue reviewing.

Signed-off-by: MaqsudMallick <maqsudmallick@gmail.com>
Signed-off-by: MaqsudMallick <maqsudmallick@gmail.com>
@alperozturk96
alperozturk96 force-pushed the fix/image-video-grid-items branch from ebfa193 to 95144c6 Compare July 21, 2026 11:43

@alperozturk96 alperozturk96 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. It looks good.

Image

@alperozturk96
alperozturk96 merged commit 28e2fcf into nextcloud:master Jul 21, 2026
16 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display of thumbmails in Files too small / do not resize

4 participants